fix: BROS-712: Free form transformation on double click#9161
fix: BROS-712: Free form transformation on double click#9161robot-ci-heartex merged 4 commits intodevelopfrom
Conversation
✅ Deploy Preview for heartex-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for label-studio-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for label-studio-docs-new-theme ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for label-studio-playground ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #9161 +/- ##
===========================================
- Coverage 66.12% 58.00% -8.12%
===========================================
Files 828 557 -271
Lines 64797 40444 -24353
Branches 10939 10954 +15
===========================================
- Hits 42846 23460 -19386
+ Misses 21947 16980 -4967
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| setTimeout(() => { | ||
| self.clearJustSelectedFlag(); | ||
| }, 300); // Clear after double-click detection window |
There was a problem hiding this comment.
might be good to clear time out on beforeDestroy or on cleanup
yyassi-heartex
left a comment
yyassi-heartex
left a comment
There was a problem hiding this comment.
minor recommendation - but looks good otherwise approving
|
/fmt |
3 participants
This PR addresses the issue when on double clicking an unselected region, the user will enter free-form transform mode for a brief second.
Before: on UNSELECTED region double-click it, the region will become selected, the transformer will appear for a brief second, then disappear.
After: on UNSELECTED region click will select the shape, double-click will enter transformation mode ONLY when the shape is selected.
Reasoning: free-form transformation is an editing operation. Most of the editing operations can only be performed on a currently selected region. Transform is no exception, so we're moving this behavior under the selected region guard.