fix: BROS-712: Free form transformation on double click #9161
+47
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for heartex-docs canceled.
|
✅ Deploy Preview for label-studio-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
✅ Deploy Preview for label-studio-playground ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #9161 +/- ##
============================================
- Coverage 66.12% 49.30% -16.82%
============================================
Files 828 557 -271
Lines 64797 40448 -24349
Branches 10939 10945 +6
============================================
- Hits 42846 19943 -22903
+ Misses 21947 20501 -1446
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Comment on lines
+456
to
+458
| setTimeout(() => { | ||
| self.clearJustSelectedFlag(); | ||
| }, 300); // Clear after double-click detection window |
Contributor
There was a problem hiding this comment.
might be good to clear time out on beforeDestroy or on cleanup
yyassi-heartex
approved these changes
Jan 12, 2026
Contributor
yyassi-heartex
left a comment
yyassi-heartex
left a comment
There was a problem hiding this comment.
minor recommendation - but looks good otherwise approving
Contributor
|
/fmt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue when on double clicking an unselected region, the user will enter free-form transform mode for a brief second.
Before: on UNSELECTED region double-click it, the region will become selected, the transformer will appear for a brief second, then disappear.
After: on UNSELECTED region click will select the shape, double-click will enter transformation mode ONLY when the shape is selected.
Reasoning: free-form transformation is an editing operation. Most of the editing operations can only be performed on a currently selected region. Transform is no exception, so we're moving this behavior under the selected region guard.