Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change TimeOnly.ToClockNotation to accept culture #1537

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

RenNagasaki
Copy link

@RenNagasaki RenNagasaki commented Aug 24, 2024

There are cases where your UI culture is not the culture you want to get the clock notation for. Added the functionality for that.
Existing implementations should not be influenced.

For me the problematic part is: I use the DefaultTimeOnlyToClockNotationConverter for english clock notation but my UI culture is 'de-DE'. I get for 08:15 -> 'a quarter past acht' instead of 'a quarter past eight'

Here is a checklist you should tick through before submitting a pull request:

  • Implementation is clean
  • Code adheres to the existing coding standards; e.g. no curlies for one-line blocks, no redundant empty lines between methods or code blocks, spaces rather than tabs, etc.
  • No Code Analysis warnings
  • There is proper unit test coverage
  • If the code is copied from StackOverflow (or a blog or OSS) full disclosure is included. That includes required license files and/or file headers explaining where the code came from with proper attribution
  • There are very few or no comments (because comments shouldn't be needed if you write clean code)
  • [] Xml documentation is added/updated for the addition/change
  • Your PR is (re)based on top of the latest commits from the main branch (more info below)
  • Link to the issue(s) you're fixing from your PR description. Use fixes #<the issue number>
  • Readme is updated if you change an existing feature or add a new one
  • Run either build.cmd or build.ps1 and ensure there are no test failures

@@ -1,4 +1,4 @@
[MemoryDiagnoser(false)]
[MemoryDiagnoser(false)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first line of every file you modified seems to be changed. Is this a modified BOM? I'm not sure if there's a preferred version in the project, but you might want to check this.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All I know is I didn't actually touch that part. 🤔
Has VS some kind of default setting? If yes then that's what changed.
I don't see any problems happening here though and kinda don't know how I could change that. Git inside VS doesn't show them as changed.
grafik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants