[WIP] Change strategy to add Weeks. Add Week property #807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also breaks lots of tests that are missing the property, not sure what we do
JUst 85 localized tests left
SimonCropp
reviewed
Feb 15, 2024
| @@ -88,8 +88,8 @@ public void HoursFromNowNotTomorrow(int hours, string expected) | |||
|
|
|||
| [Theory] | |||
| [InlineData(1, "yesterday")] | |||
| [InlineData(10, "10 days ago")] | |||
| [InlineData(27, "27 days ago")] | |||
There was a problem hiding this comment.
given this test passes in TimeUnit.Day, why would it result in week/weeks
also 10 days is no "on week"
There was a problem hiding this comment.
Good point, I think this is going to be a culture thing and then a question of how precise people would like humanizer to be.
7 days would be "a week ago", and in fact if someone asked me about something 8 days ago I might also accept "a week ago".
Perhaps I should look at making this only provide weeks if the value is one of 7,14,21,28. And then fall backs to months as expected after that 🤔
SimonCropp
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #765
This also breaks lots of tests that are missing the property, I'll work on fixing them