Skip to content

Zg/update evi typescript quickstart #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 16, 2025

Conversation

zgreathouse
Copy link
Member

evi-typescript-quickstart (improvements)

  • Bump Hume TypeScript SDK version
  • Implement new EVIWebAudioPlayer
  • Simplify implementation
  • Split out EVI integration, audio capture, and UI specific code to libs
  • Improvements to html and css (semantic elements, better organization of styles)
  • Add preview image for UI in README

@zgreathouse zgreathouse requested a review from twitchard May 16, 2025 03:41
Copy link
Contributor

@twitchard twitchard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM a definite improvement!!!

One question about the aliases thing and import @lib/.... Will this increase friction when developers using bundlers other than vite try and copy paste our example and adapt it?

@zgreathouse
Copy link
Member Author

LGTM a definite improvement!!!

One question about the aliases thing and import @lib/.... Will this increase friction when developers using bundlers other than vite try and copy paste our example and adapt it?

It would— they would have to set up the aliases with whatever bundler they are using bundler (webpack, rollup...etc). For simplicity I removed the import aliases. 🙂

@zgreathouse zgreathouse merged commit 6215aef into main May 16, 2025
1 check passed
@zgreathouse zgreathouse deleted the zg/update-evi-typescript-quickstart branch May 16, 2025 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants