Merged
Conversation
twitchard
approved these changes
May 16, 2025
Contributor
twitchard
left a comment
twitchard
left a comment
There was a problem hiding this comment.
LGTM a definite improvement!!!
One question about the aliases thing and import @lib/.... Will this increase friction when developers using bundlers other than vite try and copy paste our example and adapt it?
Member
Author
It would— they would have to set up the aliases with whatever bundler they are using bundler (webpack, rollup...etc). For simplicity I removed the import aliases. 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
evi-typescript-quickstart (improvements)
EVIWebAudioPlayer