Skip to content

Commit 7af1c64

Browse files
authored
on unmount, wait for resource cleanup before setting disconnected status (#347)
1 parent b75a00e commit 7af1c64

File tree

4 files changed

+12
-11
lines changed

4 files changed

+12
-11
lines changed

packages/embed-react/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@humeai/voice-embed-react",
3-
"version": "0.2.0-beta.17",
3+
"version": "0.2.0-beta.18",
44
"description": "",
55
"main": "./dist/index.js",
66
"module": "./dist/index.mjs",

packages/embed/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@humeai/voice-embed",
3-
"version": "0.2.0-beta.17",
3+
"version": "0.2.0-beta.18",
44
"description": "",
55
"main": "./dist/index.js",
66
"module": "./dist/index.mjs",

packages/react/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@humeai/voice-react",
3-
"version": "0.2.0-beta.17",
3+
"version": "0.2.0-beta.18",
44
"description": "",
55
"main": "./dist/index.js",
66
"module": "./dist/index.mjs",

packages/react/src/lib/VoiceProvider.tsx

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -710,14 +710,15 @@ export const VoiceProvider: FC<VoiceProviderProps> = ({
710710
useEffect(() => {
711711
// disconnect from socket when the voice provider component unmounts
712712
return () => {
713-
void disconnectAndCleanUpResources();
714-
setStatus({ value: 'disconnected' });
715-
isConnectingRef.current = false;
716-
resourceStatusRef.current = {
717-
mic: 'disconnected',
718-
audioPlayer: 'disconnected',
719-
socket: 'disconnected',
720-
};
713+
void disconnectAndCleanUpResources().then(() => {
714+
setStatus({ value: 'disconnected' });
715+
isConnectingRef.current = false;
716+
resourceStatusRef.current = {
717+
mic: 'disconnected',
718+
audioPlayer: 'disconnected',
719+
socket: 'disconnected',
720+
};
721+
});
721722
};
722723
// eslint-disable-next-line react-hooks/exhaustive-deps
723724
}, []);

0 commit comments

Comments
 (0)