Skip to content

Comments

update some disconnecting logic#345

Merged
yinishi merged 5 commits intomainfrom
yini/disconnect-cleanup
May 27, 2025
Merged

update some disconnecting logic#345
yinishi merged 5 commits intomainfrom
yini/disconnect-cleanup

Conversation

@yinishi
Copy link
Contributor

@yinishi yinishi commented May 23, 2025

  • refactor resource shutdown in the websocket onClose handler to be a promise chain to ensure we don't set disconnected status until all resources are shut down
  • update error check to account for errors that happen during the connection step
  • add isDisconnecting check to ensure messages are not sent if disconnection is in progress

@yinishi yinishi requested review from a team, KarolinaCharlinska, chrismanahan, francamps, hume-bot, klaudiuszmiotk, vpicone and zachkrall and removed request for a team May 23, 2025 17:25
@vercel
Copy link
Contributor

vercel bot commented May 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
empathic-voice-api-js-next-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 27, 2025 5:55pm

@yinishi yinishi changed the title update onClose handler update some disconnecting logic May 23, 2025
@yinishi yinishi merged commit dc3aef2 into main May 27, 2025
3 checks passed
@yinishi yinishi deleted the yini/disconnect-cleanup branch May 27, 2025 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants