Skip to content

update some disconnecting logic #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 27, 2025
Merged

update some disconnecting logic #345

merged 5 commits into from
May 27, 2025

Conversation

yinishi
Copy link
Contributor

@yinishi yinishi commented May 23, 2025

  • refactor resource shutdown in the websocket onClose handler to be a promise chain to ensure we don't set disconnected status until all resources are shut down
  • update error check to account for errors that happen during the connection step
  • add isDisconnecting check to ensure messages are not sent if disconnection is in progress

@yinishi yinishi requested review from a team, francamps, chrismanahan, zachkrall, vpicone, KarolinaCharlinska, klaudiuszmiotk and hume-bot and removed request for a team May 23, 2025 17:25
Copy link

vercel bot commented May 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
empathic-voice-api-js-next-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 27, 2025 5:55pm

@yinishi yinishi changed the title update onClose handler update some disconnecting logic May 23, 2025
@yinishi yinishi merged commit dc3aef2 into main May 27, 2025
3 checks passed
@yinishi yinishi deleted the yini/disconnect-cleanup branch May 27, 2025 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants