Skip to content

skip calling onError for audio player errors if call is disconnected #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 28, 2025
Merged

skip calling onError for audio player errors if call is disconnected #348

merged 2 commits into from
May 28, 2025

Conversation

yinishi
Copy link
Contributor

@yinishi yinishi commented May 28, 2025

  • ignore audio player errors if the call is already disconnected. This is to prevent onError from being called if the backend sends an audio message and then immediately shuts down with an service error - audioContextRef is set to null as part of the disconnect cleanup, so errors that result from that can be safely ignored.
  • also removing the disconnecting check when connect is called. I need to do a bit more digging into this issue but want to get this out to unblock us in the immediate term.

@yinishi yinishi requested review from a team, francamps, chrismanahan, zachkrall, vpicone, twitchard, garrettbo and KarolinaCharlinska and removed request for a team May 28, 2025 19:45
@vercel Vercel
Copy link

vercel bot commented May 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
empathic-voice-api-js-next-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2025 7:45pm

@yinishi yinishi merged commit 8485048 into main May 28, 2025
3 checks passed
@yinishi yinishi deleted the yini/other-disconnect-updates branch May 28, 2025 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francamps francamps francamps approved these changes

@chrismanahan chrismanahan Awaiting requested review from chrismanahan chrismanahan was automatically assigned from HumeAI/frontend-reviewers

@zachkrall zachkrall Awaiting requested review from zachkrall zachkrall was automatically assigned from HumeAI/frontend-reviewers

@vpicone vpicone Awaiting requested review from vpicone vpicone was automatically assigned from HumeAI/frontend-reviewers

@twitchard twitchard Awaiting requested review from twitchard twitchard was automatically assigned from HumeAI/frontend-reviewers

@garrettbo garrettbo Awaiting requested review from garrettbo garrettbo was automatically assigned from HumeAI/frontend-reviewers

@KarolinaCharlinska KarolinaCharlinska Awaiting requested review from KarolinaCharlinska KarolinaCharlinska was automatically assigned from HumeAI/frontend-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yinishi @francamps