Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Add tooltip to mediaplayer.py #430

Merged
merged 1 commit into from
Apr 2, 2025

Conversation

P-ict0
Copy link
Contributor

@P-ict0 P-ict0 commented Apr 1, 2025

Pull Request

Description

Following #407:

  • Added tooltip to mediaplayer.py with full song name, artist, current song position and total song duration
  • No need to update spotify.jsonc

See below for screenshots.

Type of change

Please put an x in the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (non-breaking change; modified files are limited to the documentations)
  • Technical debt (a code change that does not fix a bug or add a feature but makes something clearer for devs)
  • Other: Style of waybar module

Checklist

Please put an x in the boxes that apply:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My commit message follows the commit guidelines.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added a changelog entry.
  • I have added necessary comments/documentation to my code.
  • I have added tests to cover my changes.
  • I have tested my code locally and it works as expected.
  • All new and existing tests passed.

Screenshots

Long song name truncated + tooltip
image

Regular song, with tooltip
image

@P-ict0
Copy link
Contributor Author

P-ict0 commented Apr 1, 2025

Optional improvements:

  • Add Artwork of song

@kRHYME7
Copy link
Contributor

kRHYME7 commented Apr 1, 2025

Yes you can add the artwork.

@kRHYME7
Copy link
Contributor

kRHYME7 commented Apr 2, 2025

btw would you like to have dynamic colors for this?

image

@kRHYME7
Copy link
Contributor

kRHYME7 commented Apr 2, 2025

Ops I forgot we have builtin https://man.archlinux.org/man/extra/waybar/waybar-mpris.5.en mpris for waybar

@kRHYME7
Copy link
Contributor

kRHYME7 commented Apr 2, 2025

Will merge this now and I will add some stuff later.

@kRHYME7 kRHYME7 merged commit 1da48e9 into HyDE-Project:master Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants