-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] Add retry for auto updates #1217
Open
flavioislima
wants to merge
4
commits into
main
Choose a base branch
from
feat/retry_auto_update
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flavioislima
requested review from
jiyuu-jin,
BrettCleary,
eliobricenov,
biliesilva and
ry-animal
January 22, 2025 16:48
ry-animal
approved these changes
Jan 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Update attempts are always good
biliesilva
approved these changes
Jan 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm on Mac!
jiyuu-jin
approved these changes
Jan 22, 2025
eliobricenov
approved these changes
Jan 22, 2025
BrettCleary
approved these changes
Jan 22, 2025
flavioislima
added
PR: Ready-For-Test
PR is ready to be tested by a QA
and removed
PR: Ready-For-Review
PR is ready to be reviewed by peers
labels
Jan 22, 2025
flavioislima
force-pushed
the
feat/retry_auto_update
branch
from
January 22, 2025 21:19
4929a43
to
995f8d7
Compare
ry-animal
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to improve the robustness of the update process in the
src/backend/updater.ts
file. The most important changes introduce a retry mechanism for update attempts and enhance the logging and tracking of update errors.Improvements to update process:
updateAttempts
andMAX_UPDATE_ATTEMPTS
variables to manage the number of update retries.autoUpdater.on('error', async (error) => {
event handler to retry updates up to three times with a 5-second delay between attempts.updateAttempts
counter after all attempts fail.HOW TO TEST
Use the following Checklist if you have changed something on the Backend or Frontend: