-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Reload app for MM only on app update #1249
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's move the logic into a function that is only called in the main process
I believe this would be the correct test case https://app.qase.io/case/HC-529. We should actually go back to 0.22.4 so a mm ext version changes https://github.com/HyperPlay-Gaming/hyperplay-desktop-client/releases/tag/v0.22.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. appreciate you migrating it to the backend over time. responded on the other comment thread 👍
Tested upgrading from v0.22.4 and it worked
This pull request includes changes to improve the client update handling and extension initialization process. The most important changes include adding a new function to reload for MetaMask, modifying the frontend to reload the app when a new version is detected, and restructuring the backend to handle the new reload functionality.
Changes to client update handling:
src/backend/api/misc.ts
: Added a newreloadForMM
function to send a reload request for MetaMask.src/frontend/components/UI/AppVersion/index.tsx
: Updated theAppVersion
component to check for version changes and callreloadForMM
if a new version is detected.Changes to extension initialization:
src/backend/main.ts
: Removed the extension initialization from thefrontendReady
event and added a newreloadForMM
event to handle the initialization and reloading process. [1] [2]HOW TO TEST
Issue is that on the current version the app reloads the interface after a few seconds (~5s) every time it's opened. With
this change it will only do that after an app update.
last_version
field to a previous version (< 0.23.2)Use the following Checklist if you have changed something on the Backend or Frontend: