Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Store page while game is extracting #1254

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[Fix] Store page while game is extracting #1254

wants to merge 3 commits into from
+116 −28

Conversation

BrettCleary
Copy link
Collaborator

@BrettCleary BrettCleary commented Mar 10, 2025 •
edited
Loading

Summary

Disclaimer This is still a bit of a WIP needing testing and error handling double checked

Runs the ExtractZipService in a worker thread b wrapping ExtractZipService with ExtractZipServiceWrapper

Key benefits:

  • process.noAsar can be modified without affecting the main thread
  • performance improvements since extraction maxes out the main thread core

closes https://github.com/HyperPlay-Gaming/px-pm/issues/112

@BrettCleary BrettCleary self-assigned this Mar 10, 2025
flavioislima
flavioislima approved these changes Mar 11, 2025
View reviewed changes
Copy link
Contributor

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, I believe it is important to test this on all platforms and with the artifact just to be sure it won't break.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flavioislima flavioislima flavioislima approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

@BrettCleary BrettCleary

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BrettCleary @flavioislima