Enable default micrometer metrics #2341
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrea Lamparelli <[email protected]>
|
What do you think @stalep @johnaohara ? |
|
I think it sounds useful. Should we add some documentation to this such that users know how to connect to it via Prometheus as well? |
Oh I missed that issue 🤦🏻 we can discuss further about what approach we should follow, TBH I don't have a strong opinion on this topic.
Yeah maybe we could add some very simple documentation about the exposed metrics and how users could get get them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed
I think it would be nice to enable the default micrometer metrics to gather Horreum statistics at runtime.
Check List (Check all the applicable boxes)