Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WAS ResponseTimes: Disaggregate non-HTTP response times #302

Merged
merged 2 commits into from
Mar 24, 2025

Conversation

kgibm
Copy link
Member

@kgibm kgibm commented Mar 21, 2025

Confirmed that Dave is happy with this.

Previously, for ResponseTimes, non-HTTP work would be aggregated together into a null URI column. Instead, what this PR does is if it's non-HTTP work, then it sets the "URI" to the type of work (e.g. IIOP, MDB, etc.). This way we get response times disaggregated by the type of non-HTTP work and then this makes it easier to throw into a pivot table to break down response times of EJBs vs MDBs, etc.

Example output:

$ java -Xmx1g "-Dcom.ibm.ws390.smf.dateTimeFormat=yyyy-MM-dd'T'HH:mm:ss.SSSZ" -DPRINT_WRAPPER=false -Dcom.ibm.ws390.smf.smf1209.useTime=RESPONDED -Dcom.ibm.ws390.smf.smf1209.breakdown=BY_SERVER -jar smftools.jar "INFILE(SF.T01850.MTFTP.F001)" "PLUGIN(com.ibm.smf.was.plugins.ResponseTimes,STDOUT)"
Time,Server,Requests,AvgResponse,MaxResponse,AvgQueue,AvgDisp,AvgCPU,AvgOffload,AvgOffload%,AvgBytesRcvd,AvgBytesSent,URI
"2025-02-13T20:54:00.000+0000",LPAR1,42,1,7,0,0,0,0,0.8333333,0,0,MBean
"2025-02-13T20:54:00.000+0000",LPAR1,85,40,1426,0,40,4,2,0.6537468,0,0,MDBA
"2025-02-13T20:54:00.000+0000",LPAR1,22094,1,5102,0,1,0,0,0.43708295,533,9843,IIOP
"2025-02-13T20:54:00.000+0000",LPAR1,12,2,5,0,1,0,0,1.0,0,0,Other
"2025-02-13T20:55:00.000+0000",LPAR1,1,3,3,0,3,0,0,0.0,397,329,/Servlet1

@kgibm
Copy link
Member Author

kgibm commented Mar 21, 2025

@jbouzak Please review when you have a chance, thank you.

Copy link
Member

@jbouzak jbouzak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kgibm - please update the Copyright year for both files to 2025.

Once you do that I can approve, thanks!

Signed-off-by: Kevin Grigorenko <[email protected]>
@kgibm
Copy link
Member Author

kgibm commented Mar 24, 2025

@jbouzak Done, thanks!

@jbouzak jbouzak merged commit 538d5cd into IBM:main Mar 24, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants