fix(prefix): make use of -- as a prefix standard#50
fix(prefix): make use of -- as a prefix standard#50diego-codes wants to merge 2 commits intoIBM:masterfrom
Conversation
seejamescode
left a comment
There was a problem hiding this comment.
This would be a breaking change that I can’t really find in the BEM website.
I do understand why it is important to existing Carbon users. Would it be possible to edit the prefix in the IBM grid repo to ibm- to get this extra -?
That would be great because it would accommodate the IBM need without confusing non-IBMers.
|
Sadly we can’t make that update on the IBM grid package because it would conflict with Carbon’s prefix variable The class names themselves need to be updated to include |
|
In that case, it sounds like the real fix is changing the prefix variable in Carbon right before the grid is imported and then switching the variable back right afterwards. Would that work? Otherwise, a major change we need to do is prefix the prefix variable in Gridish. |
It adds an extra
-to the prefixing of class name so it is consistent with Carbon's prefixing standards. This is so that the$prefixvalue is respected in the building of sass code for Carbon users.