Skip to content

Add a new model to ollama action requirement and update config file #959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add a new model to ollama action requirement and update config file #959

wants to merge 4 commits into from

Conversation

jgchn
Copy link
Collaborator

@jgchn jgchn commented Jun 5, 2025 •
edited
Loading

Fix run examples to include a new model (granite3.3:8b) when setting up Ollama and also update test_run_examples.yaml configuration.

jgchn added 2 commits June 4, 2025 15:58
@jgchn
Final fix
75a1db8 
Signed-off-by: Jing Chen <[email protected]>
@jgchn
Reset max iteration back to 50
f9156c1 
Signed-off-by: Jing Chen <[email protected]>
@jgchn
Copy link
Collaborator Author

jgchn commented Jun 5, 2025 •
edited
Loading

I noticed that tips.pdl is causing Run Examples nightly test to run for very long (~3 hrs). @vazirim Do you it's okay to set MAX_ITERATIONS to a lower number like 2 and leave a comment in the file, so that

  • for local development purposes, if you were to change tips.pdl, you can get the results faster on GitHub Actions environment when you open a PR,
  • one single test doesn't stall the test for too long

WDYT?

@jgchn jgchn changed the title Add a new model to ollama action requirement Add a new model to ollama action requirement and update config file Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jgchn