Skip to content

Fix Github CI build and some minor linting issues. #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 16, 2025
Merged

Fix Github CI build and some minor linting issues. #92

merged 4 commits into from
Apr 16, 2025

Conversation

pspoerri
Copy link
Contributor

@pspoerri pspoerri commented Apr 9, 2025 •
edited
Loading

This PR includes a variety of fixes:

  • A fix of the Github CI build system due to a regression in newer versions of Ubuntu.
  • Fix conditionals in Github CI.
  • Support for Scala 2.13 in the unit tests.
  • A fix in the caching system, which might have prevented the system from working altogether.
    This line triggered a linting error due to _.
cachedFileStatus.remove(filter, _)

This was changed to

 cachedFileStatus.remove(filter, None)

@pspoerri
Fix typo in README.
b23e1f6 
Signed-off-by: Pascal Spörri <[email protected]>
@pspoerri pspoerri mentioned this pull request Apr 9, 2025
Merged
@pspoerri pspoerri force-pushed the ps/fix_pipeline branch 9 times, most recently from 65fa721 to 258a527 Compare April 9, 2025 20:39
@pspoerri pspoerri force-pushed the ps/fix_pipeline branch 3 times, most recently from 86dc261 to 791265f Compare April 9, 2025 20:59
@pspoerri
Fix Github CI build script
3b2712a 
Signed-off-by: Pascal Spörri <[email protected]>
@BernardMetzler
Copy link
Member

lgtm

@BernardMetzler BernardMetzler merged commit 0be5f0e into IBM:main Apr 16, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BernardMetzler BernardMetzler Awaiting requested review from BernardMetzler BernardMetzler is a code owner

@raduioanstoica raduioanstoica Awaiting requested review from raduioanstoica raduioanstoica is a code owner

@mwkaufma mwkaufma Awaiting requested review from mwkaufma mwkaufma is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pspoerri @BernardMetzler