Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refines the handling of thermodynamic integration and simplifies the initialization logic for equilibration control in the
calphypackage. The most important changes include fixing a reference to thesigmaparameter in the thermodynamic integration method and removing redundant conditional logic for setting the equilibration control.Fixes and improvements in thermodynamic integration:
calphy/liquid.py, corrected the reference to thesigmaparameter by ensuring it is accessed fromself.calc.uhlenbeck_ford_modelinstead ofself.uhlenbeck_ford_model. This ensures consistency and prevents potential attribute errors.Simplification of equilibration control logic:
calphy/phase.py, removed redundant conditional checks for the reference phase when setting the equilibration control. The logic now directly sets theequilibration_controlto "nose-hoover" without phase-specific conditions, simplifying the code.