feat: image rotation #383
Merged
feat: image rotation #383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caro3801
requested changes
Jul 4, 2025
| <div class="image-viewer__wrapper__controls justify-content-center d-flex gap-1 p-1"> | ||
| <button-row-action | ||
| class="image-viewer__wrapper__controls__button" | ||
| label="Rotate 90° to the left" |
There was a problem hiding this comment.
i18n: It will need to be translated, it should be replaced with i18n key interpolation
There was a problem hiding this comment.
Ah yes, I forgot about those, thank you!
| /> | ||
| <button-row-action | ||
| class="image-viewer__wrapper__controls__button" | ||
| label="Rotate 90° to the right" |
| img.onload = () => resolve(img) | ||
| img.onerror = () => reject(new Error('Unable to fetch the thumbnail')) | ||
| // This is necessary to avoid CORS issues | ||
| img.crossOrigin = 'Anonymous' |
There was a problem hiding this comment.
Good to know, thanks for the comment
| import { set } from 'lodash' | ||
| import { defineStore } from 'pinia' | ||
|
|
||
| export const useDocumentViewStore = defineStore( |
There was a problem hiding this comment.
question: could it become a performance issue at some point to store this kind of map?
There was a problem hiding this comment.
I don't think so, except if the user rotate million of images, which is very unlikely. Also most web browsers limits the local storage 5 MB.
caro3801
approved these changes
Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds control buttons to rotate an image:
Screencast.from.2025-07-04.13-41-16.webm
Notes
useImagecomposabledocumentViewstoreplayerstore should be merged into thedocumentViewstore