Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Python
multiprocessing
is not trivial to handle consistently access on the different OS + the pyinstaller executable. Using the wrong setup trigger problems such as workers not launching or hanging at application shutdown.This PRs aims at fixing these issues.
Changes
neo4j-app
Fixed
python >= 3.10.8
in order to avoid: benefit from cpython fixProcessPoolExecutor
tomultiprocessing.Pool
using thespawn
context +maxtasksperchild=1
. Usingmaxtasksperchild=1
allows the child process to be destroyed when it receivesSIGTERM
orSIGKILL
signals. Otherwise probably due to this cpython bug the pool hangs and fails to kill child processes. Since we know that Python workers will only accomplish a single task which iswork_forever
, usingmaxtasksperchild=1
is an acceptable hackChanged
pyinstaller==6.3.0
for builds