Crossflow hx

idaes/models/unit_models/heat_exchanger_1D.py

@@ -430,39 +430,62 @@ def build(self):
 
         # Set flow directions for the control volume blocks and specify
         # discretization if not specified.
-        if self.config.flow_type == HeatExchangerFlowPattern.cocurrent:
-            set_direction_hot = FlowDirection.forward
-            set_direction_cold = FlowDirection.forward
+        if self.config.hot_side.transformation_method is useDefault:
+            _log.warning(
+                "Discretization method was "
+                "not specified for the hot side of the "
+                "co-current heat exchanger. "
+                "Defaulting to finite "
+                "difference method on the hot side."
+            )
+            self.config.hot_side.transformation_method = "dae.finite_difference"
+        if self.config.cold_side.transformation_method is useDefault:
+            _log.warning(
+                "Discretization method was "
+                "not specified for the cold side of the "
+                "co-current heat exchanger. "
+                "Defaulting to finite "
+                "difference method on the cold side."
+            )
+            self.config.cold_side.transformation_method = "dae.finite_difference"
+
+        if (
+            self.config.hot_side.transformation_method
+            != self.config.cold_side.transformation_method
+        ):
+            raise ConfigurationError(
+                "HeatExchanger1D only supports similar transformation "
+                "methods on the hot and cold side domains for "
+                "both cocurrent and countercurrent flow patterns. "
+                f"Found method {self.config.hot_side.transformation_method} "
+                f"on hot side and method {self.config.cold_side.transformation_method} "
+                "on cold side."
+            )
+        if self.config.hot_side.transformation_method == "dae.collocation":
+            if (
+                self.config.hot_side.transformation_scheme is useDefault
+                or self.config.cold_side.transformation_scheme is useDefault
+            ):
+                raise ConfigurationError(
+                    "If a collocation method is used for HeatExchanger1D, the user "
+                    "must specify the transformation scheme they want to use."
+                )
             if (
-                self.config.hot_side.transformation_method
-                != self.config.cold_side.transformation_method
-            ) or (
                 self.config.hot_side.transformation_scheme
                 != self.config.cold_side.transformation_scheme
             ):
                 raise ConfigurationError(
+                    "If a collocation method is used, "
                     "HeatExchanger1D only supports similar transformation "
-                    "schemes on the hot and cold side domains for "
-                    "both cocurrent and countercurrent flow patterns."
-                )
-            if self.config.hot_side.transformation_method is useDefault:
-                _log.warning(
-                    "Discretization method was "
-                    "not specified for the hot side of the "
-                    "co-current heat exchanger. "
-                    "Defaulting to finite "
-                    "difference method on the hot side."
+                    "schemes on the hot and cold side domains. Found "
+                    f"{self.config.hot_side.transformation_scheme} scheme on "
+                    f"hot side and {self.config.cold_side.transformation_scheme} "
+                    "scheme on cold side."
                 )
-                self.config.hot_side.transformation_method = "dae.finite_difference"
-            if self.config.cold_side.transformation_method is useDefault:
-                _log.warning(
-                    "Discretization method was "
-                    "not specified for the cold side of the "
-                    "co-current heat exchanger. "
-                    "Defaulting to finite "
-                    "difference method on the cold side."
-                )
-                self.config.cold_side.transformation_method = "dae.finite_difference"
+
+        if self.config.flow_type == HeatExchangerFlowPattern.cocurrent:
+            set_direction_hot = FlowDirection.forward
+            set_direction_cold = FlowDirection.forward
             if self.config.hot_side.transformation_scheme is useDefault:
                 _log.warning(
                     "Discretization scheme was "
@@ -484,24 +507,6 @@ def build(self):
         elif self.config.flow_type == HeatExchangerFlowPattern.countercurrent:
             set_direction_hot = FlowDirection.forward
             set_direction_cold = FlowDirection.backward
-            if self.config.hot_side.transformation_method is useDefault:
-                _log.warning(
-                    "Discretization method was "
-                    "not specified for the hot side of the "
-                    "counter-current heat exchanger. "
-                    "Defaulting to finite "
-                    "difference method on the hot side."
-                )
-                self.config.hot_side.transformation_method = "dae.finite_difference"
-            if self.config.cold_side.transformation_method is useDefault:
-                _log.warning(
-                    "Discretization method was "
-                    "not specified for the cold side of the "
-                    "counter-current heat exchanger. "
-                    "Defaulting to finite "
-                    "difference method on the cold side."
-                )
-                self.config.cold_side.transformation_method = "dae.finite_difference"
             if self.config.hot_side.transformation_scheme is useDefault:
                 _log.warning(
                     "Discretization scheme was "
@@ -519,7 +524,7 @@ def build(self):
                     "Defaulting to forward finite "
                     "difference on the cold side."
                 )
-                self.config.cold_side.transformation_scheme = "BACKWARD"
+                self.config.cold_side.transformation_scheme = "FORWARD"
         else:
             raise ConfigurationError(
                 "{} HeatExchanger1D only supports cocurrent and "
@@ -776,6 +781,7 @@ def initialize_build(
         cold_side_units = (
             self.cold_side.config.property_package.get_metadata().get_derived_units
         )
+        # TODO What if there is more than one time point? What if t0 != 0?
         if duty is None:
             duty = value(
                 0.25

idaes/models_extra/power_generation/unit_models/__init__.py

@@ -15,10 +15,12 @@
 from .boiler_fireside import BoilerFireside
 from .boiler_heat_exchanger import BoilerHeatExchanger
 from .boiler_heat_exchanger_2D import HeatExchangerCrossFlow2D_Header
+from .cross_flow_heat_exchanger_1D import CrossFlowHeatExchanger1D
 from .downcomer import Downcomer
 from .drum import Drum
 from .drum1D import Drum1D
 from .feedwater_heater_0D_dynamic import FWH0DDynamic
+from .heater_1D import Heater1D
 from .heat_exchanger_3streams import HeatExchangerWith3Streams
 from .steamheater import SteamHeater
 from .waterpipe import WaterPipe