Adding initial support for v2 solvers #1384
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewlee94
requested review from
dallan-keylogic,
lbianchi-lbl and
ksbeattie
as code owners
andrewlee94
added
scaling_v2
enhancement
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## scaling_v2 #1384 +/- ##
=============================================
Coverage ? 77.58%
=============================================
Files ? 391
Lines ? 64398
Branches ? 14266
=============================================
Hits ? 49963
Misses ? 11851
Partials ? 2584 ☔ View full report in Codecov by Sentry. |
…1389) * Empty commit to verify failures on main * Resolve likely false positives * Resolve likely true positives * Resolve probable true positive * Remove "frst" from typos exclusions * Remove "ans" from typos exclusions b/c crate-ci/typos#981
* outputs * fix hyperlink * put this back * put this back2 * replace with simple hyperlink
* Updating black and rerunning it on all files * Remove duplicated Black requirement * Update Black rev in pre-commit config --------- Co-authored-by: Ludovico Bianchi <[email protected]>
andrewlee94
requested review from
AlexNoring,
aostace01,
agarciadiego and
Robbybp
as code owners
…into scaling_v2
* Catching unneccessary terms in lagrange multiplier expression * Better implementation * Adding tests for filtering inert elements
* Adding support for indexed variables in parameter sweep * Adding test for indexed vars
* Adding attributes to hold units used by MSContactor * Removing unneccessary argument and fixing tests
* add unit models * edits * changes * Code cleaning * Fix initialization * Begin adding tests * changes * test units * fix pressure drop unit issue * Moving towards heater testing * move changes from other branch * format remaining file * separate 1d hx changes * Fix pylint errors * more pylint issues * remove elevation change * run black * get rid of commented code * Fix typo * At Andrew's insistence, make methods public * address more of Andrew's comments * Update initialization to new form * documentation * Documentation in progress * remove debugging * Documentation * pitch * polishing step * run black * new black version * culling common * Docstrings and merges * spelling * pylint * more Andrew suggestions * run Black * pylint * no more values
Co-authored-by: Ludovico Bianchi <[email protected]>
…DAES#1385) * update imports of native_types and pyomo_constant_types (which is deprecated) * Adding next batch of diagnostics tests * Next batch of daignsotics tests * Work around for ASL issue * Adding more diagnostics checks * Last unit model diagnostics tests * Fixing typo * Improving fix for ASL issue * Better implementation of fix * Fixing pylint and Python 3.8 failures * Removing old implementation of workaround * Fixing noisy test * Moving registration of external functions * Reverting to version that works on Windows * Trying another way to get binary files * add parallel variable/constraint checks to report_numerical_issues; change default parallel tolerance to 1e-8 * update tests * tighten parallel_component_tolerance to 1e-8 * adjust model to make parallel variable test less sensitive * update test to reflect new default tolerance of 1e-8 * consistent format for displaying parallel tolerance --------- Co-authored-by: Andrew Lee <[email protected]>
* Fix grid integration class names * Fixing pytest marks and more TestClass names * Fixing some regexes * Fixing returns in tests * Cleaning up surrogte plotting tests * Fixing plotting modifications * Fixing some re.escapes * Fixing misused pytest fixtures * Fixing more re.escapes * Hopefully the last re.escapes * Missed re.escape * Fixing typo
* Renaming Block classes * Fixing instances of _General * Fixing other _Data classes * Some clean up * bumping Pyomo tag * Updating docs * Excluding pylint no-member warnings * Fixing pylint issue * Fixing another pylint issue
* Bumping Pyomo tag * Update pyomo tag to 6.7.2 release --------- Co-authored-by: Ludovico Bianchi <[email protected]>
Robbybp
reviewed
May 10, 2024
Comment on lines
-17
to
-26
| import idaes.logger as idaeslog | ||
| from idaes.apps.caprese.util import initialize_by_element_in_range | ||
| from idaes.apps.caprese.common.config import ( | ||
| ControlPenaltyType, | ||
| ) | ||
| from idaes.apps.caprese.common.config import VariableCategory as VC | ||
| from idaes.apps.caprese.categorize import ( | ||
| categorize_dae_variables, | ||
| CATEGORY_TYPE_MAP, | ||
| ) |
There was a problem hiding this comment.
I assume these are all unused imports being removed?
There was a problem hiding this comment.
Yes - I generally clean these up as I find them.
|
Closing this as it is out of date and will be replaced by a new PR that also selectively activates the new presolver. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First part of new scaling
Summary/Motivation:
This PR adds the first infrastructure to allow us to test the new IPOPT infterface using
get_solver. For now, scaling is turned off as we expect this to cause issues, and we will first switch to using ipopt_v2 with only the presolve.Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: