-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Publication Title from description in study_parser.py #52
base: master
Are you sure you want to change the base?
Conversation
if "Type" in component: | ||
key = "%s Description" % component["Type"] | ||
else: | ||
key = "Study Description" | ||
component_title = ( | ||
"%s\n%s" % (key, component[key])) | ||
component_title = component[key] | ||
if "Study Version History" in component: | ||
history = ("\n\nVersion History\n%s" % |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are looking into removing publication title from the description, a question is whether this heading should be kept at all for the relevant studies or if the value of this field should be more simply appended with 1-2 newlines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
by "this heading" do you mean "Study Version History"? I'm happy to remove that heading too if it's not needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We want to run this on all studies...
|
As a one-liner I have been using the following in the past to update all descriptions/annotations of the top-level containers:
|
Trying to pull this branch onto pilot-idr0125 for testing, but can't connect to github...
|
The |
That worked, thanks!
|
|
Also just ran the |
See ome/omero-mapr#74 (comment)
We want to simplify the Study
description
so that it can be parsed for searching, without duplicating the Study Title in the description.