Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve mode shape coefficients for OpenFAST, especially for 2nd modes #214

Merged
merged 5 commits into from
Jul 12, 2024

Conversation

gbarter
Copy link
Collaborator

@gbarter gbarter commented Jul 11, 2024

Purpose

Thanks to an Issue posted in the 22-MW repo, I started to dig deeper into the generation of the mode shape coefficients for OpenFAST by WISDEM and found a possibility for mistakes to arise. After improving the WISDEM logic and approach, we found that the new mode shapes are nearly identical for the first mode, but are definitely improved for the second mode.

Note that this change only impacts OpenFAST ElastoDyn users (both blade and tower).

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

  • I have run existing tests which pass locally with my changes
  • I have added new tests or examples that prove my fix is effective or that my feature works
  • I have added necessary documentation

@gbarter gbarter merged commit 7e57df8 into develop Jul 12, 2024
2 checks passed
@gbarter gbarter deleted the mode_shapes branch July 12, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant