-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update PR: Permanent portal entities #783
Open
modos189
wants to merge
38
commits into
IITC-CE:master
Choose a base branch
from
modos189:feature/update_marker
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modos189
added
enhancement
New feature or request
development
general development issue
labels
Nov 18, 2024
🤖 Pull request artifacts
|
modos189
force-pushed
the
feature/update_marker
branch
from
November 19, 2024 07:36
3e94dcb
to
de178e5
Compare
keep parsed level/team in seperate fields and back compability
apply/adapt set(Marker)Style PR IITC-CE#251 by johnd0e commit 6201837
avoid missing details when getEntities replies that the portal has changed while portal details is still fresh (3min) in cache
photo/title
use only the link timestamp for reliable timestamp
le-jeu
force-pushed
the
feature/update_marker
branch
from
November 19, 2024 14:02
de178e5
to
da84f53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces PR #437
When rebasing the PR, I had to update almost every commit, so I decided it would be better to do this as a separate PR rather than sending changes to the previous one.