T&A Bugfix #0042396: Fix Test Scoring Settings for Import/Export #8412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhelfer
commented
Nov 12, 2024
| @@ -5254,6 +5254,7 @@ public function fromXML(ilQTIAssessment $assessment) | |||
| } | |||
|
|
|||
| $this->saveToDb(); | |||
| $result_summary_settings = $result_summary_settings->withShowPassDetails($result_details_settings->getShowPassDetails()); | |||
There was a problem hiding this comment.
By default, the value of results_presentation in the tst_tests table is set to 3 if it is not specified. This results in showPassDetails() always being true.
Subsequently, result_presentation will be set to the corresponding import value (in my case, 0). However, due to this line
, it will always be set to
1. The reason for this is that PassDetails is true because it inherits the still-existing default value of 3 from the database.
@nhaagen, you seem to be the author of this feature. Please take a look at this and see if there is a better solution.
Best,
@fhelfer
There was a problem hiding this comment.
This seems to also be an issue for newer releases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://mantis.ilias.de/view.php?id=42396
Similar to e051884