Improve sampling behavior of MMuX interface #185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
alexpargon
changed the title
Signed-off-by: Alejandro Parcet <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Signed-off-by: Alejandro Parcet <[email protected]>
Signed-off-by: Alejandro Parcet <[email protected]>
Signed-off-by: Alejandro Parcet <[email protected]>
Signed-off-by: Alejandro Parcet <[email protected]>
Signed-off-by: Alejandro Parcet <[email protected]>
Signed-off-by: Alejandro Parcet <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR improves the sampling behavior of the MMuX interface by enhancing the user experience around sampling operations. The changes include better state management, improved UI feedback, and cleaner code organization.
Key changes:
- Added a
clearSamplingfunction to reset sampling state and integrated it into the UI workflow - Enhanced the PlusButton component to use Material-UI Accordion for better UX and automatic closure after sampling
- Improved context dependencies and removed unused parameters across multiple plot components
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| node/src/context/SamplingContext.tsx | Added clearSampling function and fixed context naming in console logs |
| node/src/context/JobContext.tsx | Wrapped functions in useCallback and exposed additional context values |
| node/src/components/setup/FunctionList.tsx | Integrated clearSampling function into the reset workflow |
| node/src/components/sampling/RunSamplingButton.tsx | Updated function signature and removed debug console log |
| node/src/components/sampling/PlusButton.tsx | Refactored to use Accordion component with automatic state management |
| node/src/components/sampling/LHSSampling.tsx | Reorganized context usage and moved function declaration outside component |
| node/src/components/plots/*.tsx | Removed unused inputVars parameter from CreateSelect components |
| node/src/components/navigation/Footer.tsx | Added permission-based UI rendering and improved variable naming |
| node/src/components/minmax.tsx | Removed debug console log |
| node/src/components/data/JobSelector.tsx | Added automatic job collection updates with user feedback |
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Signed-off-by: Alejandro Parcet <[email protected]>
wvangeit
approved these changes
Jul 24, 2025
Signed-off-by: Alejandro Parcet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.