Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NDTensors] Only define sort(Tuple) below Julia 1.10 #1168

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

mtfishman
Copy link
Member

This should fix #1164.

Once JuliaLang/Compat.jl#804 is merged we can just remove our definition of sort(::Tuple) entirely, which isn't a good idea to have here anyway.

@codecov-commenter
Copy link

Codecov Report

Merging #1168 (8c6faec) into main (56d7334) will decrease coverage by 30.97%.
Report is 1 commits behind head on main.
The diff coverage is 0.00%.

❗ Current head 8c6faec differs from pull request most recent head eaa3187. Consider uploading reports for the commit eaa3187 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff             @@
##             main    #1168       +/-   ##
===========================================
- Coverage   85.33%   54.36%   -30.97%     
===========================================
  Files          88       87        -1     
  Lines        8371     8319       -52     
===========================================
- Hits         7143     4523     -2620     
- Misses       1228     3796     +2568     
Files Changed Coverage Δ
src/physics/autompo/opsum_to_mpo_qn.jl 0.00% <0.00%> (-97.62%) ⬇️

... and 36 files with indirect coverage changes

@mtfishman mtfishman merged commit cfc4781 into main Jul 31, 2023
@mtfishman mtfishman deleted the NDTensors_tuple_sort_compat branch July 31, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NDTensors] [BUG] Precompilation issue with 1.10-beta1
2 participants