Skip to content

Upgrade to DerivableInterfaces v0.4 #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 10, 2025
Merged

Conversation

mtfishman
Copy link
Member

@mtfishman mtfishman commented Mar 10, 2025

Update for ITensor/DerivableInterfaces.jl#18, fixes #25.

Here are the load times with this PR:

julia> @time using SparseArraysBase, LinearMaps
  0.468702 seconds (747.44 k allocations: 76.319 MiB, 4.60% gc time, 5.54% compilation time)

@mtfishman mtfishman requested a review from lkdvos March 10, 2025 16:22
Copy link
Contributor

@lkdvos lkdvos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, happy to see that fixed!

@mtfishman
Copy link
Member Author

Nice, happy to see that fixed!

I had forgotten that is where this all started haha.

@mtfishman mtfishman merged commit d227c87 into main Mar 10, 2025
12 checks passed
@mtfishman mtfishman deleted the derivableinterfaces_v0.4 branch March 10, 2025 16:51
Copy link

codecov bot commented Mar 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.31%. Comparing base (deb81ae) to head (49bdc74).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #47      +/-   ##
==========================================
+ Coverage   75.21%   75.31%   +0.10%     
==========================================
  Files           7        7              
  Lines         472      474       +2     
==========================================
+ Hits          355      357       +2     
  Misses        117      117              
Flag Coverage Δ
docs 35.38% <0.00%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Investigate potential compilation issues related to overloading Base.cat
2 participants