Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #8 🎫: Update projects.json, Add project type badge and update projects preview files #10

Merged
merged 10 commits into from
Feb 21, 2024
Merged

Issue #8 🎫: Update projects.json, Add project type badge and update projects preview files #10

merged 10 commits into from
Feb 21, 2024

Conversation

ITurres
Copy link
Owner

@ITurres ITurres commented Feb 20, 2024 •
edited
Loading

arthur iturres logo

Pull Request Summary for Issue #8 Completion

Overview:

For the past few months I have been working on Rails and Rails + React projects. It was time to update the portfolio projects.json file to store all these new projects information.
The images of all the past and present projects have been modified to have the same size and aspect ratio. This will make the portfolio look more organized and visually appealing.
I have also added a new relatively small feature, now each project object has a projectType property that can be either solo or team, this will be used to display a badge on the project card to indicate if the project was done solo or as part of a team.

Changes Made:

Added:

Click to see Below the list of new and updated project preview images:
  • (updated) public/projects-preview/awesome-books-preview.JPG.
  • (new) public/projects-preview/blog-app-preview.jpg.
  • (updated) public/projects-preview/bookstore-preview.JPG.
  • (new) public/projects-preview/budget-app-preview.jpg.
  • (updated) public/projects-preview/ferrari-racing-website-preview.JPG.
  • (updated) public/projects-preview/finance-preview.jpg.
  • (updated) public/projects-preview/leaderboard-preview.JPG.
  • (updated) public/projects-preview/math-magicians-preview.JPG.
  • (new) public/projects-preview/my-recipes-app-preview.jpg.
  • (updated) public/projects-preview/portfolio1-preview.JPG.
  • (updated) public/projects-preview/spacex-travelers-preview.JPG.
  • (updated) public/projects-preview/task-manager-preview.JPG.
  • (new) public/projects-preview/tesla-booking-app-preview.jpg.
  • (updated) public/projects-preview/text-encrypter-preview.JPG.
  • (updated) public/projects-preview/theTimeMeister-website-preview.JPG.
  • (updated) public/projects-preview/tvmaze-preview.JPG.
  • (updated) public/projects-preview/youtube-clone-preview.JPG.

Modified:

.github/workflows/deploy.yml

  • I have changed the environment name from github-pages to development to match the branch name.

/src/components/UI/SplideCarouselSlide.tsx

  • As mentioned in the overview, I have added a new projectType property to the SplideCarouselSlideProps interface.
  • The project image is wrapped in a div an with the badge 'span' element for the project type.

/src/db/projects.json

  • I have added the new projects and updated the existing ones with the new projectType property.
  • I have also renamed all SASS references to SCSS, and CSS to CSS3 in the projects.json file.

/src/styles/pages/ProjectsPage.scss

  • I have moved the splide arrows from the sides of the carousel to the bottom, wrapping the carousel pagination by applying absolute positioning to the arrows container.
  • I have added the corresponding styles for the new projectType (class = project-type) badge.

Reasoning:

  • n/a.

Impact:

  • These changes will introduce new projects to the portfolio as well as a minor visual update to the project cards.
  • A new redeployment has been triggered to update the portfolio with the new changes.

Testing:

  • n/a.

Related Issues:

Dependencies:

  • n/a.

Additional Notes:

  • n/a.

ITurres added 10 commits February 19, 2024 22:44
@ITurres
Chore: Add new rails project preview image files
a064dd3
@ITurres
Feat: Add new rails projects data to the 'db' json
7a5cccd 
- Tesla Booking App.
- Budget App.
- My Recipes App.
- Blog App.
@ITurres
Chore: Update db/projects style tech names and position in tech-stack…
edf87ae 
… array
@ITurres
Chore: Update 'ttm-e-commerce' project description
2bddfca
@ITurres
Chore: Update all short projects preview images with heigher ones
dfe21f7
@ITurres
Feat: Add new property to 'SplideCarouselSlideProps' interface and re…
28ddf30 
…nder it

- Wrap the project image in a div wrapper and
Render the new 'projectType' property within it.
@ITurres
Styles: Update styles for Splide arrows and project type badge
6fa3055 
- Now the Splide arrows will be place at the bottom of the slider.
- The project type badge will be placed at the bottom right
  of the project image.
@ITurres
Fix: Rename the old projects '.JPG' extensions to the new preview fil…
19d3993 
…es '.jpg'
@ITurres
Chore: Update environment in 'deploy.yml'
5cd1618
@ITurres
Fix: rename all projects preview extension '.jpg' to '.JPG'
2c1e539
@ITurres ITurres added enhancement New feature or request UI/UX redeploy gh-pages deployment bug fix fixed a bug labels Feb 20, 2024
@ITurres ITurres self-assigned this Feb 20, 2024
@ITurres ITurres linked an issue Feb 20, 2024 that may be closed by this pull request
[3pt] Update projects json and re-deploy #8
Closed
@ITurres ITurres marked this pull request as ready for review February 21, 2024 19:10
@ITurres
Copy link
Owner Author

ITurres commented Feb 21, 2024

✅ Good for merge.

@ITurres ITurres merged commit 1b785c6 into development Feb 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ITurres ITurres

Labels
bug fix fixed a bug enhancement New feature or request redeploy gh-pages deployment UI/UX
Projects
⚛ Reactive portfolio - Future-Features ~ Bugs ~ Enhancements
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[3pt] Update projects json and re-deploy
1 participant
@ITurres