-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #2 🎫: Horizontal IDE like Navbar (Desktop Navbar) #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…avbar' component - src/styles/UI/LineCount.scss - src/styles/UI/Navbar.scss - src/styles/pages/AboutPage.scss - src/styles/pages/ContactPage.scss - src/styles/pages/ExpertiseSummaryPage.scss - src/styles/pages/ProjectsPage.scss
- Store the url paths in an object and memoize them. - Use the 'useLocation' hook to get the current url path. - Conditional render the active class based on the current url path.
❌ Deploy Preview for storied-pastelito-095767 failed.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
❗ Notes: Netlify and Vercel deployments have been removed. |
Merged
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary for Issue #2 Completion
Overview:
Changes Made:
Added:
.vscode/terminals.json
.vscode
directory to store the terminal settings for the project./src/components/UI/FileTabsNavbar.tsx
UI
directory to handle the new navigation concept for large screens./src/styles/UI/FileTabsNavbar.scss
FileTabsNavbar
component.Modified:
Note: the following files were modified to accommodate the new
FileTabsNavbar
component./src/components/UI/Navbar.tsx
windowWidth
variable.minWidth
variable), the pages paths will be render along with the social links as this will be the mobile view. Otherwise, only the social links will be rendered./src/components/pages/HomePage.tsx
HomePage
component. But in this case I conditionally render theFileTabsNAvbar
component based on the window width, that is, when the window width is greater than 768px (minWidth
variable), theFileTabsNavbar
component will be rendered./src/styles/UI/LineCount.scss
.line-count
class will have a margin top of 2.6rem to give space for the newFileTabsNavbar
component./src/styles/UI/Navbar.scss
$elementsInNavbar
variable from 7 to 8 since now I have the Wellfound (old AngelList) link./src/styles/pages/AboutPage.scss
component-code-snippet
will now be at the min-width 768px breakpoint with a top value of 4rem. Again this is to give space for the newFileTabsNavbar
component./src/styles/pages/ContactPage.scss
/src/styles/pages/ExpertiseSummaryPage.scss
/src/styles/pages/ProjectsPage.scss
ContactPage
,ExpertiseSummaryPage
andProjectsPage
components.Reasoning:
Impact:
Testing:
Related Issues:
Dependencies:
Additional Notes: