[ESSI-2027] use context-specific manifest metadata labels#636
Merged
Conversation
dlpierce
force-pushed
the
essi-2027_manifest_metadata_labels
branch
from
419d14a to
ac0b95b
Compare
dlpierce
approved these changes
Nov 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
iiif_printlooks up the allinson_flex Profile records directly, which makes it context-unaware. This results in always using the default label, which can result in an inconsistency with the Show page where context-aware dynamic_schema lookup is used.This patches
iiif_printbehavior to be context-aware, until such time as the issue is patched upstream.This does not currently recreate the special handling of the collection property; we should test whether that needs to be added.
Raised corresponding issue upstream at:
notch8/iiif_print#378