Skip to content

Add vitest, extract renderSize helper#235

Merged
CorrectRoadH merged 3 commits intoIceWhaleTech:mainfrom
malykhinvi:vitest
Jul 31, 2024
Merged

Add vitest, extract renderSize helper#235
CorrectRoadH merged 3 commits intoIceWhaleTech:mainfrom
malykhinvi:vitest

Conversation

@malykhinvi
Copy link
Contributor

@malykhinvi malykhinvi commented Jul 19, 2024

  1. Extract duplicated renderSize function
  2. Add vitest for unit testing
  3. Add ci GH workflow to run tests on CI
  4. Remove ZB and YB support. Due to precision loss in JS number type, these sizes are not supported. JS number supports only 2^53

@malykhinvi malykhinvi marked this pull request as ready for review July 19, 2024 10:22
@sonarqubecloud
Copy link

@CorrectRoadH
Copy link

LGTM

@CorrectRoadH CorrectRoadH merged commit 882369b into IceWhaleTech:main Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants