Favorites feature #158
Open
Favorites feature #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhoxhaa
requested changes
Jan 16, 2025
jhoxhaa
approved these changes
Jan 16, 2025
lippserd
requested changes
Jan 16, 2025
schema/mysql/schema.sql
Outdated
| @@ -1003,6 +1003,12 @@ CREATE TABLE stateful_set_owner ( | |||
| PRIMARY KEY (stateful_set_uuid, owner_uuid) | |||
| ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_bin; | |||
|
|
|||
| CREATE TABLE favorite ( | |||
| resource_uuid binary(16) NOT NULL, | |||
| username varchar(255) NOT NULL, | |||
There was a problem hiding this comment.
Should be varchar(254) COLLATE utf8mb4_unicode_ci NOT NULL to be consistent with the Icinga Web schema.
lippserd
requested changes
Jan 20, 2025
| kind varchar(255) COLLATE utf8mb4_unicode_ci NOT NULL, | ||
| username varchar(254) COLLATE utf8mb4_unicode_ci NOT NULL, | ||
| PRIMARY KEY (resource_uuid, username), | ||
| INDEX (kind, username) |
There was a problem hiding this comment.
We also always add a name for the index. Please see the Icinga DB schema for examples.
There was a problem hiding this comment.
I would also flip the index as we could add an "All My Favorites" view .
There was a problem hiding this comment.
And I would add an order/priority column. We could then also add a feature to change the display order of the favorites.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.