Skip to content

Add Icinga states to pod #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 14, 2024
Merged

Add Icinga states to pod #72

merged 4 commits into from
Jun 14, 2024

Conversation

jhoxhaa
Copy link
Contributor

@jhoxhaa jhoxhaa commented Apr 25, 2024

No description provided.

@jhoxhaa jhoxhaa self-assigned this Apr 25, 2024
@cla-bot cla-bot bot added the cla/signed CLA is signed by all contributors of a PR label Apr 25, 2024
@jhoxhaa jhoxhaa requested a review from lippserd April 25, 2024 08:35
@jhoxhaa jhoxhaa force-pushed the add-icinga-states-to-pod branch from 4d3c703 to 3b81b21 Compare April 26, 2024 12:41
@jhoxhaa jhoxhaa force-pushed the add-icinga-states-to-pod branch 3 times, most recently from 8923ef0 to 08e77ee Compare May 10, 2024 10:54
@jhoxhaa jhoxhaa force-pushed the add-icinga-states-to-pod branch 2 times, most recently from 773bbe5 to f34a587 Compare May 17, 2024 09:57
lippserd
lippserd requested changes May 22, 2024
View reviewed changes
Copy link
Member

@lippserd lippserd left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be also good to add some text which explains the state, e.g.

Init container $name terminated with non-zero exit code $code: $reason

You could add icinga_state_reason text for that.

@jhoxhaa jhoxhaa force-pushed the add-icinga-states-to-pod branch 2 times, most recently from 17ae44f to 7d8e4ed Compare May 23, 2024 07:00
@jhoxhaa jhoxhaa requested a review from lippserd May 23, 2024 08:50
@jhoxhaa jhoxhaa force-pushed the add-icinga-states-to-pod branch 7 times, most recently from c92b69a to bf0a64f Compare June 3, 2024 20:19
@jhoxhaa jhoxhaa force-pushed the add-icinga-states-to-pod branch from bf0a64f to 8a5d03c Compare June 3, 2024 21:44
@lippserd lippserd force-pushed the add-icinga-states-to-pod branch from ff9fced to 6589b48 Compare June 13, 2024 08:24
@lippserd lippserd force-pushed the add-icinga-states-to-pod branch from 6589b48 to cfd2a74 Compare June 13, 2024 08:30
@lippserd lippserd merged commit 0a7b264 into main Jun 14, 2024
7 checks passed
@lippserd lippserd deleted the add-icinga-states-to-pod branch June 14, 2024 07:46
@lippserd lippserd added this to the 0.2.0 milestone Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lippserd lippserd Awaiting requested review from lippserd

Assignees

@jhoxhaa jhoxhaa

Labels
cla/signed CLA is signed by all contributors of a PR
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jhoxhaa @lippserd