Skip to content

GHA: Linux: forbid compiler warnings #9733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

GHA: Linux: forbid compiler warnings #9733

wants to merge 1 commit into from

Conversation

Al2Klimov
Copy link
Member

No description provided.

@Al2Klimov Al2Klimov added the core/quality Improve code, libraries, algorithms, inline docs label Mar 24, 2023
@Al2Klimov Al2Klimov self-assigned this Mar 24, 2023
@cla-bot cla-bot bot added the cla/signed label Mar 24, 2023
@Al2Klimov
Copy link
Member Author

Note

On Fedora 37 (reference test case for now) it terminates with:

class_lexer.ll:52:34: error: 'string_buf.lex_buf::buf' may be used uninitialized [-Werror=maybe-uninitialized]

The following PR should fix this:

@Al2Klimov Al2Klimov force-pushed the forbid-compiler-warnings branch from dbc8dec to 0f9087f Compare April 3, 2023 09:07
@Al2Klimov
Copy link
Member Author

Now it's:

/usr/include/c++/12/bits/atomic_base.h:488:31: error: 'unsigned char __atomic_load_1(const volatile void*, int)' writing 1 byte into a region of size 0 overflows the destination [-Werror=stringop-overflow=]

@Al2Klimov
Copy link
Member Author

@julianbrost As per your instruction #9411 (review) I've tested -Werror, but 17d969a neither works at all, nor makes any sense IMAO as we'd forbid signed/unsigned and implicit copy construction, but allow string overflows. Absurd. Hence I decided to keep my origin goal: just reduce compiler warnings w/o doing anything radical. If you agree with me, please close this PR.

@Al2Klimov Al2Klimov removed their assignment Apr 3, 2023
@Al2Klimov
Copy link
Member Author

In the latter case you can also close

@Al2Klimov Al2Klimov force-pushed the forbid-compiler-warnings branch from 17d969a to f847392 Compare May 21, 2025 10:28
@Al2Klimov Al2Klimov marked this pull request as ready for review May 21, 2025 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@julianbrost julianbrost

Labels
cla/signed core/quality Improve code, libraries, algorithms, inline docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Al2Klimov @julianbrost