Skip to content

Conversation

@lippserd
Copy link
Member

@lippserd lippserd commented Oct 21, 2025

This PR switches to the new PHP workflow, which combines linting, static analysis, and unit testing. phpcs.xml and phpunit.xml have been removed, as the new workflow provides sane defaults for both and the files did not contain any special configurations anyway. Since the new workflow uses the latest PHPUnit version by default, deprecated PHPUnit features have been migrated. In addition, code style corrections were made to comply with the latest PSR coding standards.

  • After merging, I will update the branch protection required status checks to match the new workflow - below is a dry run showing what would happen.
./gh-update-branch-protection-checks/gh-update-branch-protection-checks.sh --repo Icinga/icingaweb2-module-businessprocess --pr 487 --dry-run
[INFO] Fetching PR details...
[WARNING] PR #487 is not merged; continuing anyway...
[INFO] Target branch: main
[INFO] PR head branch: php-workflows
[INFO] PR head commit SHA: c85b9d98febeda77c6c41092c816261e7e3e0ee7
[INFO] Listing workflow runs triggered by commit c85b9d98febeda77c6c41092c816261e7e3e0ee7...
[INFO] Workflow runs: 20165738029
[INFO] Listing jobs for workflow 20165738029...
[INFO] Jobs: PHP / Static analysis (8.5) / PHPStan 8.5, PHP / Static analysis (8.2) / PHPStan 8.2, PHP / Lint (8.3) / Linters 8.3, PHP / Lint (8.4) / Linters 8.4, PHP / Test (8.5) / PHPUnit 8.5, PHP / Lint (8.5) / Linters 8.5, PHP / Test (8.2) / PHPUnit 8.2, PHP / Lint (8.2) / Linters 8.2, PHP / Test (8.3) / PHPUnit 8.3, PHP / Test (8.4) / PHPUnit 8.4, PHP / Static analysis (8.4) / PHPStan 8.4, PHP / Static analysis (8.3) / PHPStan 8.3
[INFO] Fetching current branch protection required status checks...
[INFO] Comparing branch protection required status checks...
--- /dev/fd/63	2025-12-12 15:40:51.766129608 +0100
+++ /dev/fd/62	2025-12-12 15:40:51.766380317 +0100
@@ -43,27 +43,51 @@
       },
       {
         "app_id": 15368,
-        "context": "Static analysis for php 8.2 on ubuntu-latest"
+        "context": "PHP / Lint (8.2) / Linters 8.2"
       },
       {
         "app_id": 15368,
-        "context": "Static analysis for php 8.3 on ubuntu-latest"
+        "context": "PHP / Lint (8.3) / Linters 8.3"
       },
       {
         "app_id": 15368,
-        "context": "Static analysis for php 8.4 on ubuntu-latest"
+        "context": "PHP / Lint (8.4) / Linters 8.4"
       },
       {
         "app_id": 15368,
-        "context": "Unit tests with php 8.2 on ubuntu-latest"
+        "context": "PHP / Lint (8.5) / Linters 8.5"
       },
       {
         "app_id": 15368,
-        "context": "Unit tests with php 8.3 on ubuntu-latest"
+        "context": "PHP / Static analysis (8.2) / PHPStan 8.2"
       },
       {
         "app_id": 15368,
-        "context": "Unit tests with php 8.4 on ubuntu-latest"
+        "context": "PHP / Static analysis (8.3) / PHPStan 8.3"
+      },
+      {
+        "app_id": 15368,
+        "context": "PHP / Static analysis (8.4) / PHPStan 8.4"
+      },
+      {
+        "app_id": 15368,
+        "context": "PHP / Static analysis (8.5) / PHPStan 8.5"
+      },
+      {
+        "app_id": 15368,
+        "context": "PHP / Test (8.2) / PHPUnit 8.2"
+      },
+      {
+        "app_id": 15368,
+        "context": "PHP / Test (8.3) / PHPUnit 8.3"
+      },
+      {
+        "app_id": 15368,
+        "context": "PHP / Test (8.4) / PHPUnit 8.4"
+      },
+      {
+        "app_id": 15368,
+        "context": "PHP / Test (8.5) / PHPUnit 8.5"
       }
     ],
     "contexts_url": "https://api.github.com/repos/Icinga/icingaweb2-module-businessprocess/branches/main/protection/required_status_checks/contexts",
[SUCCESS] [dry-run] No changes applied.

@cla-bot cla-bot bot added the cla/signed label Oct 21, 2025
@lippserd lippserd force-pushed the php-workflows branch 2 times, most recently from bb5a875 to 2e6223c Compare October 22, 2025 10:57
@lippserd lippserd marked this pull request as ready for review December 12, 2025 14:41
@lippserd lippserd merged commit b4b41f7 into main Dec 15, 2025
13 checks passed
@lippserd lippserd deleted the php-workflows branch December 15, 2025 08:29
@lippserd
Copy link
Member Author

I have updated the branch protection required status checks to match the new workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants