Remove monitoring module dependency
#492
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukhwinder33445
force-pushed
the
fix/remove-monitoring-module-dependency
branch
2 times, most recently
from
ff4e5db to
ac0635c
Compare
By separating `monitoring` module controllers. - Adjust view-script paths accordingly
…essage - Host|ServiceController: The extended class `CompatController` has its own tabs. Therefore, set the view script tabs to null to avoid creating tabs twice. - View-scripts: Add a condition to create tabs only when the `monitoring` backend (ido[Host|Service]Controller) is used.
sukhwinder33445
force-pushed
the
fix/remove-monitoring-module-dependency
branch
from
ac0635c to
d17c450
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #491
The controllers for
icingadband themonitoringbackend have been separated to remove the unwanted dependency.Minor adjustments made to the view scripts so that it can be used by both backends.