Add support for 'Dependency Redundancy Groups' #2860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ref/NC/805863 |
|
@Donien Please rebase with master and resolve conflicts |
Donien
force-pushed
the
add-dependency-redundancy-group
branch
from
4feb84f to
13b93d1
Compare
|
@raviks789 Should be okay now. |
raviks789
requested changes
Feb 11, 2025
Donien
force-pushed
the
add-dependency-redundancy-group
branch
from
13b93d1 to
01c6c0c
Compare
raviks789
reviewed
Jun 2, 2025
|
|
||
| INSERT INTO director_schema_migration | ||
| (schema_version, migration_time) | ||
| VALUES (189, NOW()); |
There was a problem hiding this comment.
Raise the schema version number to 190. And change the file name to upgrade_190.sql.
Donien
force-pushed
the
add-dependency-redundancy-group
branch
from
01c6c0c to
9a11ed5
Compare
|
Hi @raviks789, please have another look. Everything should be fine now after rebase and suggested changes. |
raviks789
requested changes
Jun 18, 2025
| . ' whole dependency to be fulfilled.' | ||
| ), | ||
| 'class' => "director-suggest", | ||
| 'data-suggestion-context' => 'dependencyredundancygroups', |
There was a problem hiding this comment.
Suggested change
| 'data-suggestion-context' => 'dependencyredundancygroups', | |
| 'data-suggestion-context' => 'dependencyRedundancyGroups', |
I know that the methods are case insensitive in PHP, but it is still desirable to match cases for consistency and readability reasons.
Donien
force-pushed
the
add-dependency-redundancy-group
branch
from
9a11ed5 to
2102c17
Compare
|
Done. Thanks again for your continued support on this, @raviks789 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Icinga2 version 2.14.0 introduced dependency redundancy groups which allow for more flexiblity when it comes to determining the "reachability" of a host (e.g. multiple DNS servers as redundant dependencies).
This PR adds a new attribute "redundancy_group" to dependencies and adjusts the web forms accordingly.
If any changes need to be made, please let me know.