Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github Actions: Add Phpstan #186

Merged
merged 11 commits into from
Sep 1, 2023
Merged

Github Actions: Add Phpstan #186

merged 11 commits into from
Sep 1, 2023

Conversation

sukhwinder33445
Copy link
Contributor

No description provided.

@sukhwinder33445 sukhwinder33445 self-assigned this Jun 19, 2023
@cla-bot cla-bot bot added the cla/signed label Jun 19, 2023
@yhabteab yhabteab force-pushed the phpstan branch 4 times, most recently from 8165e7c to fe95667 Compare August 16, 2023 15:25
@yhabteab yhabteab added the enhancement New feature or improvement label Aug 16, 2023
@yhabteab yhabteab added this to the 1.3.0 milestone Aug 16, 2023
@yhabteab yhabteab force-pushed the phpstan branch 14 times, most recently from d1255ba to fa39f39 Compare August 23, 2023 13:05
@yhabteab
Copy link
Member

yhabteab commented Aug 23, 2023

The remaining errors should be fine, once all phpstan branches of ipl libraries are merged and the nightly branch is updated.

.github/workflows/php.yml Outdated Show resolved Hide resolved
application/controllers/CertificatesController.php Outdated Show resolved Hide resolved
application/controllers/UsageController.php Outdated Show resolved Hide resolved
phpstan.neon Outdated Show resolved Hide resolved
phpstan.neon Show resolved Hide resolved
Copy link
Contributor Author

@sukhwinder33445 sukhwinder33445 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

yhabteab
yhabteab previously approved these changes Sep 1, 2023
@yhabteab
Copy link
Member

yhabteab commented Sep 1, 2023

Depends on Icinga/ipl-html#130

@yhabteab yhabteab merged commit c2cce53 into main Sep 1, 2023
6 checks passed
@yhabteab yhabteab deleted the phpstan branch September 1, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla/signed enhancement New feature or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants