Fix issuer subject_hash ambiguities & bogus results with unknown issuers
#240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhabteab
force-pushed
the
fix-check-command
branch
from
e5f198c to
4afdb84
Compare
yhabteab
force-pushed
the
fix-check-command
branch
from
4afdb84 to
e37d370
Compare
yhabteab
force-pushed
the
fix-check-command
branch
from
e37d370 to
ab0edff
Compare
yhabteab
changed the title
CheckCommand misbehaviour with self-signed certssubject_hash ambiguities & bogus results with unknown issuers
yhabteab
force-pushed
the
fix-check-command
branch
2 times, most recently
from
55c2c3b to
110fa8e
Compare
It doesn't make sense to directly join on the `issuer` here at all. The join was utilized to determine if the certificate with `link.order = 0` is self-seigned, but this often results in incorrect conclusions, as most of the issuers are self-signed. Instead, the `self_signed` column available for each certificate should be used for this purpose.
yhabteab
force-pushed
the
fix-check-command
branch
from
110fa8e to
0fa141d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #232
ref/IP/54844