Menu navigation: Improve flyout transition #5367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raviks789
force-pushed
the
improve-flyout-hover-transition
branch
3 times, most recently
from
c921d83 to
49dae2c
Compare
raviks789
force-pushed
the
improve-flyout-hover-transition
branch
from
49dae2c to
21c491b
Compare
nilmerg
requested changes
May 7, 2025
Member
nilmerg
left a comment
nilmerg
left a comment
There was a problem hiding this comment.
Please use always const instead of let, unless let is required.
raviks789
force-pushed
the
improve-flyout-hover-transition
branch
2 times, most recently
from
d1173dc to
5d7dfcf
Compare
raviks789
force-pushed
the
improve-flyout-hover-transition
branch
from
5d7dfcf to
b551ab6
Compare
flourish86
previously approved these changes
May 8, 2025
Contributor
flourish86
left a comment
flourish86
left a comment
There was a problem hiding this comment.
Obviously the preview triangle should be removed in the end but as tested, this works really well now.
nilmerg
requested changes
May 8, 2025
Member
nilmerg
left a comment
nilmerg
left a comment
There was a problem hiding this comment.
And remove the visible triangle now please
raviks789
force-pushed
the
improve-flyout-hover-transition
branch
8 times, most recently
from
3d4ac4d to
6581d4b
Compare
raviks789
force-pushed
the
improve-flyout-hover-transition
branch
from
6581d4b to
8b52c06
Compare
nilmerg
requested changes
May 8, 2025
raviks789
force-pushed
the
improve-flyout-hover-transition
branch
from
05bbc16 to
57f7b4b
Compare
raviks789
force-pushed
the
improve-flyout-hover-transition
branch
from
57f7b4b to
48863da
Compare
nilmerg
approved these changes
May 8, 2025
Member
nilmerg
left a comment
nilmerg
left a comment
There was a problem hiding this comment.
It even works perfect in the collapsed menu 🎉
nilmerg
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #5160