-
-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Flutter][3.22.0] fix accentColor & textTheme #276
base: master
Are you sure you want to change the base?
Conversation
Got this error with the fix, even with an "empty" NeumorphicApp() (using Flutter 3.10 and Dart3) If someone is blocked with this and dont want to downgrade Flutter SDK, just use a MaterialApp for testing The following assertion was thrown building NeumorphicApp(dirty): The relevant error-causing widget was: When the exception was thrown, this was the stack: |
7c9c810
to
ad0b488
Compare
@thomasnappee |
Works perfectly 👍 |
@florent37 while the project doesn't seem to be actively maintained, could you please still take a look at this critical compatibility PR? |
Should this project be forked so that these issues can be fixed, otherwise this package is likely to die? |
A fork published on pub.dev means people willing to continue maintaining it. For my own purposes I forked and then applied "dart fix" which did a fine job as far as I can see with no effort required from me. So now my project refers to my fork, and unless a graver and more difficult update is required, that should do for the foreseeable future. |
@scttbloom, you can fork this project into your own repository, make the fix, for example using @den0206 changes then replace the pub.dev version of the package with you github version. An example of how to do this is in this link https://stackoverflow.com/questions/54022704/how-to-add-a-package-from-github-in-flutter. |
i need this fix |
Please merge it) |
fix two property
accentColor
(depracated) =>Theme.of(context).colorScheme.secondary
reftextTheme
(depracated)Fixed to build with Flutter 3.10.0.