Fix related to WebSocket #158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm connecting to HeishaMon via an SSH tunnel. I access the application on a port other than 80 — in my case, it's 81. Unfortunately, the software doesn't work correctly and throws the following error: `Uncaught SyntaxError: Failed to construct 'WebSocket': The URL 'ws://127.0.0.2:81:80/ws' is invalid.` In the `htmlcode.h` file, the WebSocket connection unnecessarily forces port 80. This is not needed, because the port is automatically added in `location.host` as long as it differs from the default one (80 for `ws` and 443 for `wss`).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm connecting to HeishaMon via an SSH tunnel. I access the application on a port other than 80 — in my case, it's 81. Unfortunately, the software doesn't work correctly and throws the following error:
Uncaught SyntaxError: Failed to construct 'WebSocket': The URL 'ws://127.0.0.2:81:80/ws' is invalid.In thehtmlcode.hfile, the WebSocket connection unnecessarily forces port 80. This is not needed, because the port is automatically added inlocation.hostas long as it differs from the default one (80 forwsand 443 forwss).