Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

USDScene : Fix writing of UsdLux lights #1376

Merged
merged 3 commits into from
Aug 4, 2023
Merged

USDScene : Fix writing of UsdLux lights #1376

merged 3 commits into from
Aug 4, 2023

Commits on Aug 3, 2023

  1. USD ShaderAlgo : Add missing exports

    @johnhaddon
    johnhaddon committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    aab95d3 View commit details
    Browse the repository at this point in the history

  2. USDScene : Fix writing of UsdLux lights 

    We were writing them as regular material assignments before, which might have round-tripped back into Gaffer OK, but which were not what other USD clients needed. We need to make sure that the primary shader is written as a `UsdLux*Light` prim, and that any input shaders are stored as children of that prim.

We still share most of the implementation with the generic material-writing code, but with differences in orchestration. It would have been possible to continue to do this with one `writeShaderNetwork()` uber-function internally with a bunch of conditionals depending on whether or not we were writing lights. But I felt that it was clearer and more maintainable to have two small top-level functions that each made appropriate calls to a set of shared utility functions.
    @johnhaddon
    johnhaddon committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    f174f8d View commit details
    Browse the repository at this point in the history

  3. USD ShaderAlgo : Fix writing of SdfAssetPath and TfToken inputs 

    These cases occur when writing to UsdLuxLight types where the inputs already exist, and don't need to be defined by us.
    @johnhaddon
    johnhaddon committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    b6fa2b7 View commit details
    Browse the repository at this point in the history