-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IECoreUSD : Import some core USD modules before _IECoreUSD #1384
Conversation
This doesn't seem too unreasonable to me, as long as we add a comment explaining why it's there, and we also clean up the namespace so that |
f43d0b3
to
bc36bb5
Compare
Switched to import and added comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've nitpicked a spelling mistake, but mostly because I also need to ask what branch you need this merging to - I assume it's not main
?
# In the ImageEngine env, if _IECoreUSD is imported before these pxr modules, | ||
# we get a weird exception when we later load the pxr modules. We're not | ||
# 100% sure why this is happening, but importing them first isn't | ||
# unreasonble. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unreasonble -> unreasonable
bc36bb5
to
b2838de
Compare
Without this, at IE, we get the warning message: SystemError: initialization of _tf raised unreported exception I don't know whether this is a reasonable solution, but I think I'll just PR it for discussion.
b2838de
to
97eae7f
Compare
Fixed typo and retargeted to RB-10.5 ( I don't think it's an issue before 10.5 ) |
I have no idea if this is the right solution, but I figured I'd PR it for discussion.
In the IE Gaffer 1.3 env, when launching Gaffer, I get this printed to console:
It appears that importing _IECoreUSD before initializing some of the USD stuff is causing things to get initialized in the wrong order or something, and it then causes problems when the pxr module goes to actually initialize things.
This does not seem to be happening in public Gaffer. IE is on USD 22.03, so maybe newer USD has fixed this, intentionally or unintentionally?
It doesn't seem unreasonable to import a couple of USD modules first ... maybe this is a reasonable solution even if it's not totally clear why it's needed?