Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE Cortex Updates for VFX Platform 2023 #1440

Merged
merged 10 commits into from
Nov 4, 2024

Conversation

ivanimanishi
Copy link
Member

This PR includes all recent changes needed at IE to get cortex to build with VFX Platform 2023 dependencies, as well as running inside Houdini 20.0 and 20.5, Maya 2024 and Nuke 15.

Checklist

  • I have read the contribution guidelines.
  • I have updated the documentation, if applicable.
  • I have tested my change(s) in the test suite, and added new test cases where necessary.
  • My code follows the Cortex project's prevailing coding style and conventions.

ivanimanishi and others added 9 commits November 1, 2024 17:33
Commit 0195899 updated
`MeshAlgo::segment` to use the new `MeshSplitter` introduced in commit
bf2040e.

The MeshSplitter does not preserve Vertex order as of now, which leads
to changes in corner and crease Ids.

NOTE: The round trip from Houdini Geometry to a Cortex MeshPrimitive
and back to Houdini Geometry still works correctly. Corner and crease
data is applied at the correct point positions, just the point number
changes
@ivanimanishi
Copy link
Member Author

@johnhaddon , you don't need to look at all the commits, since many only pertain to IE's pipeline.
But you may want to look at the changes to SConstruct and see if anything might cause you issues.
Also, we are moving away from creating symlinks to the compatibility version after install, which is something that gaffer doesn't need either, right? So we could consider removing that feature completely at some point, though we may want to wait for a new major version.

Copy link
Member

@johnhaddon johnhaddon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Removing the symlink stuff completely for the next major version would be fine for us - we don't need it in Gaffer.

I think @danieldresser is intending to restore the vertex order for the mesh segmentation, so we should be able to switch that test back before too long.

Cheers...
John

@ivanimanishi ivanimanishi merged commit 6ac8fc2 into ImageEngine:RB-10.5 Nov 4, 2024
5 checks passed
@ivanimanishi ivanimanishi deleted the ieCortexUpdates branch November 4, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants