-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IE Cortex Updates for VFX Platform 2023 #1440
IE Cortex Updates for VFX Platform 2023 #1440
Conversation
Also includes style changes.
Commit 0195899 updated `MeshAlgo::segment` to use the new `MeshSplitter` introduced in commit bf2040e. The MeshSplitter does not preserve Vertex order as of now, which leads to changes in corner and crease Ids. NOTE: The round trip from Houdini Geometry to a Cortex MeshPrimitive and back to Houdini Geometry still works correctly. Corner and crease data is applied at the correct point positions, just the point number changes
550eb73
to
9ead39d
Compare
@johnhaddon , you don't need to look at all the commits, since many only pertain to IE's pipeline. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Removing the symlink stuff completely for the next major version would be fine for us - we don't need it in Gaffer.
I think @danieldresser is intending to restore the vertex order for the mesh segmentation, so we should be able to switch that test back before too long.
Cheers...
John
This PR includes all recent changes needed at IE to get cortex to build with VFX Platform 2023 dependencies, as well as running inside Houdini 20.0 and 20.5, Maya 2024 and Nuke 15.
Checklist