Fix issue38 handle u+2028 character in data line parsing#39
Open
FelippeNO wants to merge 3 commits intoImgkl:mainfrom
Open
Fix issue38 handle u+2028 character in data line parsing#39FelippeNO wants to merge 3 commits intoImgkl:mainfrom
FelippeNO wants to merge 3 commits intoImgkl:mainfrom
Conversation
|
some tests for your PR would be helpful |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
lineRegex.firstMatch(dataLine)!statement fails when the input contains the U+2028 character (Line Separator). This issue occurs because:onErrorcallback is never invoked.Solution
try-catchto ensure errors are properly handled.