#785 - define JPMS module names #787
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 12, 2025
Djaytan
force-pushed
the
build/define-jpms-modules-name
branch
from
fabfff2 to
090ed76
Compare
## Summary The goal of this change is to encourage Gradle to put the framework's Jar files in the module path instead of the classpath. For that, we need to explicitly define the `Automatic-Module-Name` attribute in the `MANIFEST.MF` files in framework's Jar files (source: https://docs.gradle.org/current/userguide/java_library_plugin.html#using_libraries_that_are_not_modules). The newly added attribute follows this format: `<groupId>.<moduleName>` (e.g. `org.incendo.cloud.core`). Details about this change can be found here: Incendo#785. ## Impact There is no impact nor on maintainer side nor or consumer one not relying on JPMS. For the ones already relying on JPMS (e.g. Maven users), they will just have to adapt the references in their `module-info.java` files as follow: From: ```java module my.module { [...] requires cloud.core; [...] } ``` To: ```java module my.module { [...] requires org.incendo.cloud.core; [...] } ``` Closes Incendo#785
Djaytan
force-pushed
the
build/define-jpms-modules-name
branch
from
090ed76 to
878a12f
Compare
This was referenced Jan 12, 2025
Djaytan
added a commit
to Djaytan/cloud-translations
that referenced
this pull request
Jan 14, 2025
_This change is similar to Incendo/cloud#787
Djaytan
added a commit
to Djaytan/cloud-discord
that referenced
this pull request
Jan 14, 2025
_This change is similar to Incendo/cloud#787
Djaytan
added a commit
to Djaytan/cloud-spring
that referenced
this pull request
Jan 14, 2025
_This change is similar to Incendo/cloud#787
Djaytan
added a commit
to Djaytan/cloud-cli
that referenced
this pull request
Jan 14, 2025
_This change is similar to Incendo/cloud#787
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The goal of this change is to encourage Gradle to put the framework's Jar files in the module path instead of the classpath. For that, we need to explicitly define the
Automatic-Module-Nameattribute in theMANIFEST.MFfiles in framework's Jar files (source).The newly added attribute follows this format:
<groupId>.<moduleName>(e.g.org.incendo.cloud.core).Details about this change can be found here: #785.
Impact
There is no impact nor on maintainer side nor or consumer one not relying on JPMS.
For the ones already relying on JPMS (e.g. Maven users), they will just have to adapt the references in their
module-info.javafiles as follow:From:
To:
Closes #785