feat: add timeout to controller.py #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Walker <[email protected]>
dbluhm
reviewed
Aug 29, 2023
controller/controller.py
Outdated
| [event.payload.get(key) == value for key, value in values.items()] | ||
| ) | ||
| event = await asyncio.wait_for( | ||
| self.event_queue.get( |
There was a problem hiding this comment.
This is really close! As it turns out, the event_queue.get method takes a timeout parameter so we can use that instead of the asyncio.wait_for in this method. (Under the hood, this is exactly what the event_queue.get method is doing so the methodology is good!)
Signed-off-by: Alex Walker <[email protected]>
|
Subtle note: The get method forces it to be a int. We can either change this or leave it be, let me know! :) |
dbluhm
approved these changes
Aug 29, 2023
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requested from Daniel ~
Original Post:
Re: timeouts, we would need to adjust the timeouts on the
record_with_value callswhich is actually happening in theprotocolsmethods we're calling, I think. We'd need to update the acapy-minimal-examplecontrollerto allow us to set a default timeout.