-
Notifications
You must be signed in to change notification settings - Fork 1.3k
feat(fips): native FIPS support #3973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) |
frontend/src/pages/auth/SignUpSsoPage/components/UserInfoSSOStep/UserInfoSSOStep.tsx
Show resolved
Hide resolved
...-manager/SettingsPage/components/RebuildSecretIndicesSection/RebuildSecretIndicesSection.tsx
Show resolved
Hide resolved
sheensantoscapadngan
previously approved these changes
Jul 11, 2025
Merging at a later time as this is high-impact |
akhilmhdh
reviewed
Jul 13, 2025
maidul98
reviewed
Jul 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
implementation looks good, just left some minor comments
backend/src/db/migrations/20250602155451_fix-secret-versions.ts
Outdated
Show resolved
Hide resolved
maidul98
approved these changes
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📣
Native FIPS support
This PR introduces FIPS validation support (enterprise-only) for plain Infisical installations. There is no way to migrate from non-FIPS -> FIPS, so things doesn't need to be backwards compatible with each other.
Core changes:
cryptographyFactory
), which will handle all exports of crypto. This way we can be very explicit about what crypto we are using.jsonwebtoken
is replaced with our own JWT implementation using native Node.To test things out, you can run
make up-dev
. Development node will now always run in FIPS-mode to ensure that we aren't developing features that won't be compatible with FIPS.Type ✨